Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): add AppServiceJavaVersion #6249

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

chaniglik
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

New/Edited policies (Delete if not relevant)

Description

This code defines a function called AppServiceJavaVersion that performs a check on the Java version configuration in Web Apps (Web Apps) in the Azure service. The function checks if the Java version defined for the application is the latest version (version 11), and returns a test result accordingly. The function uses the Checkov library to perform the check, and imports constants and functions from it.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AppServiceJavaVersion is already implemented here - #6243
and the MSSQLServerMinTLSVersion is already implemented here - #6245
Can we remove it from one of the PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants