Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(general): Update README links for PyPi #6231

Merged
merged 2 commits into from May 9, 2024

Conversation

KPCOFGS
Copy link
Contributor

@KPCOFGS KPCOFGS commented May 2, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Changed relative paths to absolute paths for PyPI project site compatibilities

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tsmithv11
Copy link
Collaborator

These links are not broken. Any reason you're looking to hardcode the paths?

@KPCOFGS
Copy link
Contributor Author

KPCOFGS commented May 8, 2024

Hi! Thank you for your feedback, If you would get on the PyPI website, by clicking on the links I pointed out, these then lead to 404 error because PyPI website doesn't handle these links in a right way

@tsmithv11 tsmithv11 changed the title Update README.md docs(general): Update README.md May 8, 2024
@tsmithv11 tsmithv11 changed the title docs(general): Update README.md docs(general): Update README links for PyPi May 8, 2024
@tsmithv11 tsmithv11 merged commit 3e985c5 into bridgecrewio:main May 9, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants