Skip to content

Commit

Permalink
Fix 'parameter name omitted' warning in sysfeature rapl interfaces
Browse files Browse the repository at this point in the history
  • Loading branch information
@TomTheBear
TomTheBear committed Nov 15, 2024
1 parent f70a5dc commit c5cbdf6
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions src/sysFeatures_amd_rapl.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ static int amd_rapl_energy_status_getter(const LikwidDevice_t device, char** val
/* Amd RAPL (PKG domain) */
/*********************************************************************************************************************/

static int pkg_test_testFunc(uint64_t msrData, void *)
static int pkg_test_testFunc(uint64_t msrData, void * value)
{
if (amd_rapl_pkg_info.powerUnit == 0 && amd_rapl_pkg_info.energyUnit == 0 && amd_rapl_pkg_info.timeUnit == 0)
{
Expand Down Expand Up @@ -80,7 +80,7 @@ static const _SysFeatureList amd_rapl_pkg_feature_list = {
/* AMD RAPL (CORE domain) */
/*********************************************************************************************************************/

static int core_test_testFunc(uint64_t msrData, void *)
static int core_test_testFunc(uint64_t msrData, void * value)
{
if (amd_rapl_core_info.powerUnit == 0 && amd_rapl_core_info.energyUnit == 0 && amd_rapl_core_info.timeUnit == 0)
{
Expand Down Expand Up @@ -120,7 +120,7 @@ static const _SysFeatureList amd_rapl_core_feature_list = {
/* AMD RAPL (L3 domain) */
/*********************************************************************************************************************/

static int l3_test_testFunc(uint64_t msrData, void *)
static int l3_test_testFunc(uint64_t msrData, void * value)
{
if (amd_rapl_l3_info.powerUnit == 0 && amd_rapl_l3_info.energyUnit == 0 && amd_rapl_l3_info.timeUnit == 0)
{
Expand Down
20 changes: 10 additions & 10 deletions src/sysFeatures_intel_rapl.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ static int intel_rapl_policy_setter(const LikwidDevice_t device, const char* val
/* Intel RAPL (PKG domain) */
/*********************************************************************************************************************/

static int pkg_test_testFunc(uint64_t msrData, void *)
static int pkg_test_testFunc(uint64_t msrData, void * value)
{
if (intel_rapl_pkg_info.powerUnit == 0 && intel_rapl_pkg_info.energyUnit == 0 && intel_rapl_pkg_info.timeUnit == 0)
{
Expand All @@ -330,7 +330,7 @@ static int intel_rapl_pkg_test(void)
return likwid_sysft_foreach_socket_testmsr_cb(MSR_RAPL_POWER_UNIT, pkg_test_testFunc, NULL);
}

static int pkg_limit_test_lock_testFunc(uint64_t msrData, void *)
static int pkg_limit_test_lock_testFunc(uint64_t msrData, void * value)
{
return field64(msrData, 63, 1);
}
Expand Down Expand Up @@ -486,7 +486,7 @@ static const _SysFeatureList intel_rapl_pkg_feature_list = {
/* Intel RAPL (DRAM domain) */
/*********************************************************************************************************************/

static int dram_test_testFunc(uint64_t msrData, void *)
static int dram_test_testFunc(uint64_t msrData, void * value)
{
if (intel_rapl_dram_info.powerUnit == 0 && intel_rapl_dram_info.energyUnit == 0 && intel_rapl_dram_info.timeUnit == 0)
{
Expand Down Expand Up @@ -535,7 +535,7 @@ static int intel_dram_energy_limit_test(void)
return likwid_sysft_foreach_socket_testmsr(MSR_DRAM_RAPL_POWER_LIMIT);
}

static int dram_limit_test_lock_testFunc(uint64_t msrData, void *)
static int dram_limit_test_lock_testFunc(uint64_t msrData, void * value)
{
return field64(msrData, 31, 1);
}
Expand Down Expand Up @@ -631,7 +631,7 @@ static const _SysFeatureList intel_rapl_dram_feature_list = {
/* Intel RAPL (PSYS or PLATFORM domain) */
/*********************************************************************************************************************/

static int psys_test_testFunc(uint64_t msrData, void *)
static int psys_test_testFunc(uint64_t msrData, void * value)
{
if (intel_rapl_psys_info.powerUnit == 0 && intel_rapl_psys_info.energyUnit == 0 && intel_rapl_psys_info.timeUnit == 0)
{
Expand Down Expand Up @@ -667,7 +667,7 @@ static int intel_psys_energy_limit_test(void)
return likwid_sysft_foreach_socket_testmsr(MSR_PLATFORM_POWER_LIMIT);
}

static int psys_limit_test_lock_testFunc(uint64_t msrData, void *)
static int psys_limit_test_lock_testFunc(uint64_t msrData, void * value)
{
return field64(msrData, 63, 1);
}
Expand Down Expand Up @@ -779,7 +779,7 @@ static const _SysFeatureList intel_rapl_psys_feature_list = {
/* Intel RAPL (PP0 domain) */
/*********************************************************************************************************************/

static int pp0_test_testFunc(uint64_t msrData, void *)
static int pp0_test_testFunc(uint64_t msrData, void * value)
{
if (intel_rapl_pp0_info.powerUnit == 0 && intel_rapl_pp0_info.energyUnit == 0 && intel_rapl_pp0_info.timeUnit == 0)
{
Expand Down Expand Up @@ -810,7 +810,7 @@ static int intel_pp0_energy_limit_test(void)
return likwid_sysft_foreach_socket_testmsr(MSR_PP0_RAPL_POWER_LIMIT);
}

static int pp0_limit_test_lock_testFunc(uint64_t msrData, void *)
static int pp0_limit_test_lock_testFunc(uint64_t msrData, void * value)
{
return field64(msrData, 31, 1);
}
Expand Down Expand Up @@ -894,7 +894,7 @@ static const _SysFeatureList intel_rapl_pp0_feature_list = {
/* Intel RAPL (PP1 domain) */
/*********************************************************************************************************************/

static int pp1_test_testFunc(uint64_t msrData, void *)
static int pp1_test_testFunc(uint64_t msrData, void * value)
{
if (intel_rapl_pp1_info.powerUnit == 0 && intel_rapl_pp1_info.energyUnit == 0 && intel_rapl_pp1_info.timeUnit == 0)
{
Expand Down Expand Up @@ -925,7 +925,7 @@ static int intel_pp1_energy_limit_test(void)
return likwid_sysft_foreach_socket_testmsr(MSR_PP1_RAPL_POWER_LIMIT);
}

static int pp1_limit_test_lock(uint64_t msrData, void *)
static int pp1_limit_test_lock(uint64_t msrData, void * value)
{
return field64(msrData, 31, 1);
}
Expand Down

0 comments on commit c5cbdf6

Please sign in to comment.