Fixing compiler warnings

bench/Makefile

@@ -116,7 +116,7 @@ $(BUILD_DIR):
 #PATTERN RULES
 $(BUILD_DIR)/%.o:  %.c
 	@echo "===>  COMPILE C $@"
-	$(Q)$(CC) -g -c $(DEBUG_FLAGS) $(CFLAGS) $(ANSI_CFLAGS) $(CPPFLAGS) $(TARGET_LIB) $< -o $@
+	$(Q)$(CC) -g -c $(DEBUG_FLAGS) $(CFLAGS) $(ANSI_CFLAGS) $(CPPFLAGS) $< -o $@
 	$(Q)$(CC) -g $(DEBUG_FLAGS) $(CPPFLAGS) -MT $(@:.d=.o) -MM  $< > $(BUILD_DIR)/$*.d
 
 

bench/includes/isa_armv8.h

@@ -92,6 +92,7 @@ int footer(struct bstrList* code, char* funcname)
     bstrListAddChar(code, "#endif");
 
     bdestroy(line);
+    return 0;
 }
 
 int loopheader(struct bstrList* code, char* loopname, int step)

bench/src/ptt2asm.c

@@ -459,7 +459,7 @@ struct bstrList* dynbench_getall()
         dp = ownopendir(bdata(path));
         if (dp != NULL)
         {
-            while (ep = readdir(dp))
+            while ((ep = readdir(dp)))
             {
                 if (strncmp(&(ep->d_name[strlen(ep->d_name)-4]), ".ptt", 4) == 0)
                 {

src/access-daemon/accessDaemon.c

@@ -178,7 +178,7 @@ static int getNumberOfNumaNodes()
     dp = opendir ("/sys/devices/system/node/");
     if (dp != NULL)
     {
-        while (ep = readdir (dp))
+        while ((ep = readdir (dp)))
         {
             if (fnmatch("node?*", ep->d_name, FNM_PATHNAME) == 0)
             {
@@ -840,6 +840,8 @@ static int allowed_pci_skx(PciDeviceType type, uint32_t reg)
                 (reg == MSR_UNC_SKX_M3UPI_PMON_BOX_STATUS))
                 return 1;
             break;
+        default:
+            break;
     }
     return 0;
 }

src/access-daemon/setFreqDaemon.c

@@ -570,6 +570,8 @@ static int freq_read(FreqDataRecord *rec)
         case FREQ_LOC_GOV:
             read_fd = f->set_gov;
             break;
+        default:
+            break;
     }
     if (read_fd < 0)
     {

src/frequency_cpu.c

@@ -500,6 +500,8 @@ static int freq_send_direct(FreqDataRecordType type, FreqDataRecordLocation loc,
                 lseek(fd, 0, SEEK_SET);
                 ret = read(fd, data, len);
                 break;
+            default:
+                break;
         }
         if (ret < 0)
             return ret;
@@ -565,6 +567,8 @@ static int freq_send_client(FreqDataRecordType type, FreqDataRecordLocation loc,
                 case FREQ_ERR_UNKNOWN:
                     return -EBADF;
                     break;
+                default:
+                    break;
             }
             return -1;
         }

src/ghash.c

@@ -335,10 +335,10 @@ g_hash_table_remove(GHashTable *hash_table, gpointer key)
     {
         int* key_ptr = (int*)key;
         int keyint = *key_ptr;
-        int idx = g_hash_table_lookup_node(hash_table, key_ptr, &hashret);
+        int idx = g_hash_table_lookup_node(hash_table, key_ptr, (guint*)&hashret);
         g_hash_table_remove_node(hash_table, idx);
-
     }
+    return 0;
 }
 
 static void

src/includes/perfmon_ivybridge.h

@@ -66,7 +66,7 @@ int perfmon_init_ivybridge(int cpu_id)
     lock_acquire((int*) &socket_lock[affinity_thread2socket_lookup[cpu_id]], cpu_id);
     lock_acquire((int*) &tile_lock[affinity_thread2core_lookup[cpu_id]], cpu_id);
     HPMwrite(cpu_id, MSR_DEV, MSR_PEBS_ENABLE, 0x0ULL);
-    if ((cpuid_info.model == IVYBRIDGE_EP))
+    if (cpuid_info.model == IVYBRIDGE_EP)
     {
         ivy_cbox_setup = ivbep_cbox_setup;
         ivb_did_cbox_test = 1;

src/includes/perfmon_sandybridge.h

@@ -64,7 +64,7 @@ int perfmon_init_sandybridge(int cpu_id)
     lock_acquire((int*) &tile_lock[affinity_thread2core_lookup[cpu_id]], cpu_id);
     CHECK_MSR_WRITE_ERROR(HPMwrite(cpu_id, MSR_DEV, MSR_PEBS_ENABLE, 0x0ULL));
 
-    if ((cpuid_info.model == SANDYBRIDGE_EP))
+    if (cpuid_info.model == SANDYBRIDGE_EP)
     {
         sandy_cbox_setup = snbep_cbox_setup;
         snb_did_cbox_test = 1;

src/includes/perfmon_skylake.h

@@ -797,7 +797,7 @@ int perfmon_setupCounterThread_skylake(
                 {
                     uint64_t flags = 0x0;
                     HPMread(cpu_id, MSR_DEV, TSX_FORCE_ABORT, &flags);
-                    if (flags & 0x1 == 0)
+                    if ((flags & 0x1) == 0)
                     {
                         fprintf(stderr, "Warning: Counter PMC3 cannot be used if Restricted Transactional Memory feature is enabled and\n");
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(5,2,0)

src/luawid.c

@@ -1952,7 +1952,7 @@ parse(char *line, char **argv)
                  *line != '\t' && *line != '\n')
                line++;             /* skip the argument until ...    */
      }
-     *argv = '\0';                 /* mark the end of argument list  */
+     *argv = (char *)'\0';                 /* mark the end of argument list  */
 }
 
 /* #####   FUNCTION DEFINITIONS  -  LOCAL TO THIS SOURCE FILE   ########### */
@@ -2355,6 +2355,7 @@ lua_likwid_resetRegion(lua_State* L)
 {
     const char* tag = (const char*)luaL_checkstring(L, -1);
     lua_pushinteger(L, likwid_markerResetRegion(tag));
+    return 1;
 }
 
 static int

src/perfgroup.c

@@ -197,7 +197,7 @@ perfgroup_getGroups(
     }
     i = 0;
     s = 0;
-    while (ep = readdir(dp))
+    while ((ep = readdir(dp)))
     {
         if (strncmp(&(ep->d_name[strlen(ep->d_name)-4]), ".txt", 4) == 0)
         {
@@ -218,7 +218,7 @@ perfgroup_getGroups(
         }
         if (search_home)
         {
-            while (ep = readdir(dp))
+            while ((ep = readdir(dp)))
             {
                 if (strncmp(&(ep->d_name[strlen(ep->d_name)-4]), ".txt", 4) == 0)
                 {
@@ -296,7 +296,7 @@ perfgroup_getGroups(
     i = 0;
     int skip_group = 0;
 
-    while (ep = readdir(dp))
+    while ((ep = readdir(dp)))
     {
         if (strncmp(&(ep->d_name[strlen(ep->d_name)-4]), ".txt", 4) == 0)
         {
@@ -444,7 +444,7 @@ perfgroup_getGroups(
     else
     {
         dp = opendir(homepath);
-        while (ep = readdir(dp))
+        while ((ep = readdir(dp)))
         {
             if (strncmp(&(ep->d_name[strlen(ep->d_name)-4]), ".txt", 4) == 0)
             {

src/topology_proc.c

@@ -472,7 +472,7 @@ proc_init_cpuFeatures(void)
             setBit(cpuid_info.featureFlags, RDSEED);
             bcatcstr(bfeatures, "RDSEED ");
         }
-        else if ((bisstemeqblk(flaglist->entry[i], "avx512", 6) == 1) && (!testBit(cpuid_info.featureFlags, AVX512)))
+        else if ((bisstemeqblk(flaglist->entry[i], "avx512", 6) == 1) && (!(testBit(cpuid_info.featureFlags, AVX512))))
         {
             setBit(cpuid_info.featureFlags, AVX512);
             bcatcstr(bfeatures, "AVX512 ");
@@ -564,7 +564,7 @@ proc_init_cpuFeatures(void)
         }
     }
 
-    if (testBit(cpuid_info.featureFlags, SSSE3) && !testBit(cpuid_info.featureFlags, SSE3))
+    if (testBit(cpuid_info.featureFlags, SSSE3) && (!(testBit(cpuid_info.featureFlags, SSE3))))
     {
         setBit(cpuid_info.featureFlags, SSE3);
         bcatcstr(bfeatures, "SSE3 ");
@@ -682,7 +682,7 @@ void proc_split_llc_check(CacheLevel* llc_cache)
         fprintf(stderr, "No NUMA support (no folder %s)\n", "/sys/devices/system/node");
         return;
     }
-    while (ep = readdir(dp))
+    while ((ep = readdir(dp)))
     {
         if (strncmp(ep->d_name, "node", 4) == 0)
         {
@@ -696,7 +696,7 @@ void proc_split_llc_check(CacheLevel* llc_cache)
         fprintf(stderr, "No NUMA support (no folder %s)\n", "/sys/devices/system/node/node0/");
         return;
     }
-    while (ep = readdir(dp))
+    while ((ep = readdir(dp)))
     {
         if (strncmp(ep->d_name, "cpu", 3) == 0 &&
             ep->d_name[strlen(ep->d_name)-1] >= '0' &&