Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VerticalTab] Move the new tab button to appear immediately after the last tab (uplift to 1.75.x) #27301

Open
wants to merge 3 commits into
base: 1.75.x
Choose a base branch
from

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 22, 2025

Uplift of #27117 #27289 #27284
Resolves brave/brave-browser#42533
Resolves brave/brave-browser#43226
Resolves brave/brave-browser#43374
Resolves brave/brave-browser#43375

NOTE: The main issue for this PR is brave/brave-browser#42533.
The other issues are revealed or regressed issue from this button position change.
So, included all related fixes in this uplift PR.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team January 22, 2025 00:20
@brave-builds brave-builds added this to the 1.75.x - Beta milestone Jan 22, 2025
@brave-builds brave-builds self-assigned this Jan 22, 2025
…unpinned_vertical_tab

Show separator between pinned and unpinned when both are not empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants