[ads] Only load purchase intent resource if the user has joined Brave…

… Rewards and opted-in to notification ads
brave · May 28, 2024 · d53b1a9 · d53b1a9
1 parent edc58ea
commit d53b1a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/...s/core/internal/targeting/behavioral/purchase_intent/resource/purchase_intent_resource.cc b/...s/core/internal/targeting/behavioral/purchase_intent/resource/purchase_intent_resource.cc
@@ -23,7 +23,7 @@ namespace brave_ads {
 namespace {
 
 bool DoesRequireResource() {
-  return UserHasOptedInToBraveNewsAds() || UserHasOptedInToNotificationAds();
+  return UserHasOptedInToNotificationAds();
 }
 
 }  // namespace

diff --git a/...ternal/targeting/behavioral/purchase_intent/resource/purchase_intent_resource_unittest.cc b/...ternal/targeting/behavioral/purchase_intent/resource/purchase_intent_resource_unittest.cc
@@ -84,12 +84,10 @@ TEST_F(BraveAdsPurchaseIntentResourceTest, LoadResourceWhenLocaleDidChange) {
   EXPECT_TRUE(resource_->IsInitialized());
 }
 
-TEST_F(
-    BraveAdsPurchaseIntentResourceTest,
-    DoNotLoadResourceWhenLocaleDidChangeIfOptedOutOfNotificationAdsAndBraveNewsAds) {
+TEST_F(BraveAdsPurchaseIntentResourceTest,
+       DoNotLoadResourceWhenLocaleDidChangeIfOptedOutOfNotificationAds) {
   // Arrange
   test::OptOutOfNotificationAds();
-  test::OptOutOfBraveNewsAds();
 
   ASSERT_FALSE(LoadResource(kCountryComponentId));
 
@@ -126,12 +124,11 @@ TEST_F(BraveAdsPurchaseIntentResourceTest,
 
 TEST_F(
     BraveAdsPurchaseIntentResourceTest,
-    DoNotLoadResourceWhenOptedInToNotificationAdsPrefDidChangeIfOptedOutOfNotificationAdsAndBraveNewsAds) {
+    DoNotLoadResourceWhenOptedInToNotificationAdsPrefDidChangeIfOptedOutOfNotificationAds) {
   // Arrange
   ASSERT_TRUE(LoadResource(kCountryComponentId));
 
   test::OptOutOfNotificationAds();
-  test::OptOutOfBraveNewsAds();
 
   // Act
   NotifyPrefDidChange(prefs::kOptedInToNotificationAds);
@@ -167,10 +164,9 @@ TEST_F(
 
 TEST_F(
     BraveAdsPurchaseIntentResourceTest,
-    DoNotLoadResourceWhenDidUpdateResourceComponentIfOptedOutOfNotificationAdsAndBraveNewsAds) {
+    DoNotLoadResourceWhenDidUpdateResourceComponentIfOptedOutOfNotificationAds) {
   // Arrange
   test::OptOutOfNotificationAds();
-  test::OptOutOfBraveNewsAds();
 
   // Act & Assert
   EXPECT_FALSE(LoadResource(kCountryComponentId));