Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically label issues based on regular expression matches in title and description #38107

Merged
merged 1 commit into from May 13, 2024

Conversation

wknapik
Copy link
Contributor

@wknapik wknapik commented May 6, 2024

This is an implementation based on https://github.com/github/issue-labeler. The action has some quirks, but it's maintained by GitHub and security approved. If we don't like the behavior, we could potentially switch to something else, or even implement our own from scratch.

I added some patterns to start, but the expectation is that others would add more.

Please assign as reviewers and/or tag anyone who should see this and comment.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik requested review from kjozwiak, bsclifton, rebron and a team May 6, 2024 19:59
@wknapik wknapik self-assigned this May 6, 2024
@kjozwiak
Copy link
Member

kjozwiak commented May 6, 2024

@wknapik just curious, do we have any example of how the new labels will look with the above change? Once merged, it will scan the body of issues and apply labels automatically? What happens if someone manually adds one of the OS/ labels that we already have created? Will it add another one or just skip it?

@wknapik
Copy link
Contributor Author

wknapik commented May 7, 2024

@kjozwiak once merged, each time an issue is opened, or edited, this action would run and add any missing labels based on patterns matched. Each label can only occur once, so there would be no duplication.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjozwiak once merged, each time an issue is opened, or edited, this action would run and add any missing labels based on patterns matched. Each label can only occur once, so there would be no duplication.

SGTM 👍 Always ++ on anything that will make life easier. Can always adjust/play it by ear if we notice certain labels not being added or incorrectly being added.

Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ LGTM

@wknapik wknapik merged commit 8b0b236 into master May 13, 2024
5 checks passed
@wknapik wknapik deleted the wknapik-auto-label-issues branch May 13, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants