Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Capacity Block Hack #548

Merged
merged 2 commits into from
May 7, 2024
Merged

Revert Capacity Block Hack #548

merged 2 commits into from
May 7, 2024

Conversation

hspencer77
Copy link

  • Fix merge from main
  • Revert capacity-block hack

Description

Revert capacity-block hack due to the fact that when capacity block reservations are not used, and on-demand capacity reservations are available, it generates the following error in CloudFormation:

   Resource handler returned message: "You must use a valid fully-formed launch template. The market type (purchasing) option is not valid. Choose a different market type and try again (Service: AutoScaling, Status Code: 400, Request ID: 4506edbb-da90-435c-842c-ea06cceb3c0f)" (RequestToken: b47abf27-7560-0ffe-0e4c-d7091fa935dd, HandlerErrorCode: InvalidRequest)

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@hspencer77 hspencer77 self-assigned this May 7, 2024
@hspencer77 hspencer77 added the kind/improvement product improvement label May 7, 2024
@hspencer77 hspencer77 merged commit 299f790 into main May 7, 2024
6 of 7 checks passed
@hspencer77 hspencer77 deleted the revert_capacity_block_hack branch May 7, 2024 16:38
hspencer77 added a commit that referenced this pull request Aug 4, 2024
* Fix merge from main

* Revert capacity-block hack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement product improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant