Hints #2
Merged
Hints #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethlove
commented
Nov 17, 2023
chrisjones-brack3t
approved these changes
Dec 13, 2023
| from django.core.exceptions import ImproperlyConfigured | ||
|
|
||
|
|
||
| class BracketsConfigurationError(ImproperlyConfigured): |
| from .redirects import RedirectMixin | ||
|
|
||
| if TYPE_CHECKING: # pragma: no cover | ||
| from collections.abc import Callable | ||
| from typing import Any, Optional, TypeAlias | ||
| from typing import Any |
There was a problem hiding this comment.
Does this need to be here? I swore the if TYPE_CHECKING: was mainly for preventing circular imports?
src/brackets/mixins/http.py
Outdated
Comment on lines
18
to
20
| A: TypeAlias = tuple[Any] | ||
| K: TypeAlias = dict[str, Any] | ||
| _View: TypeAlias = tuple[HttpRequest, tuple[Any], dict[str, Any]] |
There was a problem hiding this comment.
Eh. I mean I get it but it's kind of ugly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I'm ready to release.