prevent creating identical agreements #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylipp
force-pushed
the
prevent-creating-identical-agreements
branch
2 times, most recently
from
bb45eea
to
2ca794a
Compare
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 71.78% 71.87% +0.09%
==========================================
Files 280 280
Lines 7084 7101 +17
Branches 1506 1507 +1
==========================================
+ Hits 5085 5104 +19
Misses 1963 1963
+ Partials 36 34 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pylipp
force-pushed
the
prevent-creating-identical-agreements
branch
from
2ca794a
to
82f0a01
Compare
pylipp
force-pushed
the
prevent-creating-identical-agreements
branch
from
82f0a01
to
a3306d3
Compare
Partly already covered by test 2.2.2
From the GraphQL interface, a Date type is passed in. For the data level, but also for the business logic, it needs to be converted into a timezone-aware UTC datetime. This should happen as early as possible in create_transfer_agreement(); and for clarity it's moved into a separate method. Set default for valid_from to current time there. This implicitly fixes a bug that occurred when validUntil was specified but validFrom was not.
pylipp
force-pushed
the
prevent-creating-identical-agreements
branch
from
a3306d3
to
c5d2b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an agreement, now it is first checked whether an identical accepted agreement exists, i.e. same set of organisations and same (sub)set of bases involved, and overlapping validity periods. If so, the GraphQL response contains an error with
BAD_USER_INPUTcode.