Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multi box assign tags #869

Merged
merged 9 commits into from
Jul 25, 2023
Merged

Conversation

HaGuesto
Copy link
Member

@HaGuesto HaGuesto commented Jul 25, 2023

This PR enables adding tags to multiple Boxes at once through the Boxtribute Qr-Reader in MultiBox mode.

please check tests 3.4.7 as reference

@HaGuesto
Copy link
Member Author

@HaGuesto HaGuesto marked this pull request as ready for review July 25, 2023 16:22
@HaGuesto HaGuesto requested a review from pylipp July 25, 2023 16:22
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #869 (b1b9b2f) into master (93545ad) will increase coverage by 0.38%.
The diff coverage is 94.48%.

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
+ Coverage   71.13%   71.51%   +0.38%     
==========================================
  Files         279      280       +1     
  Lines        6918     7035     +117     
  Branches     1435     1479      +44     
==========================================
+ Hits         4921     5031     +110     
- Misses       1961     1967       +6     
- Partials       36       37       +1     
Flag Coverage Δ
backend 96.76% <ø> (ø)
frontend 52.01% <94.48%> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
react/src/views/Box/BoxView.tsx 60.97% <ø> (ø)
react/src/tests/helpers.ts 89.18% <66.66%> (-2.24%) ⬇️
react/src/hooks/useAssignTags.ts 92.72% <92.72%> (ø)
...omponents/QrReader/components/QrReaderMultiBox.tsx 98.07% <94.11%> (-1.93%) ⬇️
.../QrReader/components/QrReaderMultiBoxContainer.tsx 99.00% <96.96%> (-1.00%) ⬇️
.../src/components/QrReader/components/AlertTexts.tsx 85.71% <100.00%> (+3.89%) ⬆️
react/src/mocks/tags.ts 100.00% <100.00%> (ø)
react/src/queries/dynamic-mutations.ts 100.00% <100.00%> (ø)
react/src/queries/fragments.ts 100.00% <100.00%> (ø)
react/src/queries/queries.ts 100.00% <100.00%> (ø)

@HaGuesto HaGuesto merged commit 5b1c5fe into master Jul 25, 2023
5 checks passed
@HaGuesto HaGuesto deleted the feature/multi_box_assign_tags branch July 25, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant