Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning for iPhone QR-scanning behavior #1699

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions front/src/components/QrReader/QrReaderContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ const CAMERA_NOT_PERMITED_TEXT =
"Camera access was denied. Please unblock camera access in the address bar and reload the page.";
const CAMERA_NOT_PERMITED_TEXT_SAFARI_IOS =
'Camera access was denied. Please allow camera access in the address bar by selecting AA > Website Settings > Camera > "Allow".';
const IPHONE_WARNING_TEXT = (
<p>
<strong>Known Issue</strong>
<br />
We are experiencing problems with QR scanning on iPhone only. If you are also experiencing
issues, please contact us so we can add it to our investigation.
</p>
);

function QrReaderContainer({ onSuccess }: IQrReaderContainerProps) {
const { baseId } = useBaseIdParam();
Expand Down Expand Up @@ -174,6 +182,12 @@ function QrReaderContainer({ onSuccess }: IQrReaderContainerProps) {

return (
<>
{isIOS && (
<>
<AlertWithoutAction type="warning" alertText={IPHONE_WARNING_TEXT} />
<br />
</>
)}
{isCameraNotPermited && (
<>
<AlertWithoutAction
Expand Down