This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Add version facts #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
December 5, 2014 13:21
This means a more up-to-date version of rspec-puppet, so we can do better mocking and more complex tests
As it now uses the `java_version` fact
If Java is not present, we should return nil
Was updated in rspec-puppet, from @rodjek's blog: ``` This matcher has now been deprecated and will be removed in the next major release. The reason this is on it's way out is that it doesn't support parameterised classes and this has caused a lot of confusion for many users. ```
If we're using EOS, might as well make it accurate
See https://bugs.openjdk.java.net/browse/JDK-8027686 for full details, bug was fixed in u71.
|
@dgoodlad mind having a lookover? 👍 |
|
Beauty. Thanks @petems ! |
|
Shipped in 1.8.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up the elements of #48 into smaller bitesize pieces 👍
This gives new facts
::java_versionand::java_patch_levelThis means, even before there's a solid fix for #48, you can easily add some logic in your manifests to only update Java when versions out of date.
This will also fix #49, by adding some logic around checking if on OSX 10.10 and failing if release too old.