Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages: Update containerd to 1.7.17 #4016

Merged
merged 2 commits into from
Jun 11, 2024
Merged

packages: Update containerd to 1.7.17 #4016

merged 2 commits into from
Jun 11, 2024

Conversation

KCSesh
Copy link
Contributor

@KCSesh KCSesh commented May 31, 2024 •
edited

Issue number:

Related, but does not close: #3876

Description of changes:

  • Update Containerd to 1.7.17

Testing done:

  • aws-k8s-129
aarch64-aws-k8s-129-conformance            Test        passed           392         0       7019   4a957831    2024-05-23T02:53:17Z
aarch64-aws-k8s-129-nvidia-conformance     Test        passed           392         0       7019   4a957831    2024-05-23T02:43:00Z
aarch64-aws-k8s-129-nvidia-quick           Test        passed             5         0       7406   4a957831    2024-05-23T00:52:10Z
aarch64-aws-k8s-129-quick                  Test        passed             5         0       7406   4a957831    2024-05-23T01:03:34Z

x86-64-aws-k8s-129-conformance             Test        passed           392         0       7019   4a957831    2024-05-23T02:50:41Z
x86-64-aws-k8s-129-nvidia-conformance      Test        passed           392         0       7019   4a957831    2024-05-23T02:38:02Z
x86-64-aws-k8s-129-nvidia-quick            Test        passed             5         0       7406   4a957831    2024-05-23T00:44:36Z
x86-64-aws-k8s-129-quick                   Test        passed             5         0       7406   4a957831    2024-05-23T00:58:20Z
  • aws-k8s-123
aarch64-aws-k8s-123-conformance            Test        passed           346         0       6706   4a957831    2024-05-23T02:12:05Z
aarch64-aws-k8s-123-nvidia-conformance     Test        passed           346         0       6706   4a957831    2024-05-23T02:15:39Z
aarch64-aws-k8s-123-nvidia-quick           Test        passed             1         0       7051   4a957831    2024-05-23T00:40:55Z
aarch64-aws-k8s-123-quick                  Test        passed             1         0       7051   4a957831    2024-05-23T00:36:46Z

x86-64-aws-k8s-123-conformance             Test        passed           346         0       6706   4a957831    2024-05-23T02:05:07Z
x86-64-aws-k8s-123-nvidia-conformance      Test        passed           346         0       6706   4a957831    2024-05-23T01:49:25Z
x86-64-aws-k8s-123-nvidia-quick            Test        passed             1         0       7051   4a957831    2024-05-23T00:12:53Z
x86-64-aws-k8s-123-quick                   Test        passed             1         0       7051   4a957831    2024-05-23T00:30:29Z
  • (Manual) aws-k8s-130 on 129 cluster for x86:
cat podlogs/sonobuoy/sonobuoy-e2e-job-c72559fcd0ec402a/logs/e2e.txt | grep -i "RAN" -C 1
====================================================
Random Seed: 1716483254 - will randomize all specs

--

Ran 388 of 7407 Specs in 6498.991 seconds
SUCCESS! -- 388 Passed | 0 Failed | 0 Pending | 7019 Skipped
--

Ginkgo ran 1 suite in 1h48m20.037665331s
Test Suite Passed
  • aws-ecs-2:
aarch64-aws-ecs-2-conformance              Test        passed             1         0          0   4a957831    2024-05-23T01:24:13Z
aarch64-aws-ecs-2-nvidia-conformance       Test        passed             1         0          0   4a957831    2024-05-23T01:46:37Z
aarch64-aws-ecs-2-nvidia-quick             Test        passed             1         0          0   4a957831    2024-05-23T01:44:37Z
aarch64-aws-ecs-2-quick                    Test        passed             1         0          0   4a957831    2024-05-23T01:22:29Z

x86-64-aws-ecs-2-conformance               Test        passed             1         0          0   4a957831    2024-05-23T01:19:10Z
x86-64-aws-ecs-2-nvidia-conformance        Test        passed             1         0          0   4a957831    2024-05-23T01:41:07Z
x86-64-aws-ecs-2-nvidia-quick              Test        passed             1         0          0   4a957831    2024-05-23T01:39:08Z
x86-64-aws-ecs-2-quick                     Test        passed             1         0          0   4a957831    2024-05-23T01:17:43Z
  • aws-ecs-1:
aarch64-aws-ecs-1-conformance              Test        passed             1         0          0   4a957831    2024-05-23T01:14:24Z
aarch64-aws-ecs-1-nvidia-conformance       Test        passed             1         0          0   4a957831    2024-05-23T01:35:23Z
aarch64-aws-ecs-1-nvidia-quick             Test        passed             1         0          0   4a957831    2024-05-23T01:33:29Z
aarch64-aws-ecs-1-quick                    Test        passed             1         0          0   4a957831    2024-05-23T01:12:42Z

x86-64-aws-ecs-1-conformance               Test        passed             1         0          0   4a957831    2024-05-23T01:09:54Z
x86-64-aws-ecs-1-nvidia-conformance        Test        passed             1         0          0   4a957831     2024-05-23T21:49:13Z
x86-64-aws-ecs-1-nvidia-quick              Test        passed             1         0          0   4a957831     2024-05-23T21:44:47Z
x86-64-aws-ecs-1-quick                     Test        passed             1         0          0   4a957831    2024-05-23T01:07:35Z

ecs-internal-test suite

Passed
  • (Manual) Migrations and API Testing
Test 1: 
* [Setup] 1.20.0 BR image running k8 with ctr 1.6.31, with a deployed container to a node via kubectl. 
* [Test] Upgrade BR image to my custom AMI (running @ 1.21.0) with ctr 1.7.17
* [Verification] Container deployed via kubectl on 1.20.0 is running healthy on 1.21.0 via containerd 1.7

Test 2:
* [Setup] custom 1.21.0 BR image running k8 with ctr 1.7.17, with a deployed container to a node via kubectl. 
* [Test] Downgrade BR image to AMI (running @ 1.20.0) with ctr 1.6.31
* [Verification] Container deployed via kubectl on 1.21.0 via containerd 1.7.17 is running healthy on 1.20.0 via containerd 1.6.31

Test 3:
[Verification] Verified that apiclient get some of the container api's on custom 1.21.0 via containerd 1.7.17
    * container-runtime
    * oci-defaults
    * oci-hooks
    * container-registry

Test 4:
* [Setup] Set `apiclient set settings.container-runtime.max-concurrent-downloads=33` on 1.20.0 via containerd 1.6.21
* [Verification] container-runtime.max-concurrent-downloads=33 still set in 1.21.0 running containerd-1.7.17 after the migration. 

Test 5:
* [Setup] Set `apiclient set settings.container-registry.credentials` via containerd 1.7.17.
* [Verification] Private ECR access

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@KCSesh KCSesh marked this pull request as ready for review June 11, 2024 14:46
@KCSesh KCSesh merged commit c6a1e49 into bottlerocket-os:develop Jun 11, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaldo2792 arnaldo2792 arnaldo2792 approved these changes

@yeazelm yeazelm yeazelm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrading containerd version to 1.7.x
3 participants
@KCSesh @arnaldo2792 @yeazelm