New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor string parsing #998

Merged

grisumbras merged 1 commit into boostorg:develop from grisumbras:refactor/parse_escaped

May 28, 2024

+497 −638

Member

grisumbras commented Mar 29, 2024

No description provided.

cppalliance-bot commented Mar 30, 2024

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/998/pullrequest.html

grisumbras force-pushed the refactor/parse_escaped branch 2 times, most recently from cb9e0d6 to 51a56e0 Compare

March 30, 2024 11:05

codecov bot commented Mar 30, 2024 •

edited

Codecov Report

Attention: Patch coverage is 97.68212% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 93.34%. Comparing base (c5c19cf) to head (c4af9af).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #998      +/-   ##
===========================================
- Coverage    93.41%   93.34%   -0.07%     
===========================================
  Files           87       87              
  Lines         8547     8490      -57     
===========================================
- Hits          7984     7925      -59     
- Misses         563      565       +2

Files	Coverage Δ
include/boost/json/basic_parser.hpp	`100.00% <ø> (ø)`
include/boost/json/basic_parser_impl.hpp	`98.35% <97.68%> (-0.14%)`	⬇️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c19cf...c4af9af. Read the comment docs.

grisumbras force-pushed the refactor/parse_escaped branch from 51a56e0 to f49c73a Compare

March 30, 2024 11:51

cppalliance-bot commented Mar 30, 2024

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/998/pullrequest.html

cppalliance-bot commented Apr 1, 2024

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/998/pullrequest.html

grisumbras force-pushed the refactor/parse_escaped branch from 03b39c3 to bcc8bfd Compare

May 13, 2024 13:25

cppalliance-bot commented May 13, 2024

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/998/pullrequest.html

grisumbras force-pushed the refactor/parse_escaped branch from bcc8bfd to d9ca101 Compare

May 27, 2024 19:26


refactor string parsing

c4af9af

grisumbras force-pushed the refactor/parse_escaped branch from d9ca101 to c4af9af Compare

May 27, 2024 20:15

cppalliance-bot commented May 27, 2024

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/998/pullrequest.html

grisumbras merged commit c4af9af into boostorg:develop

5 checks passed

grisumbras deleted the refactor/parse_escaped branch

May 28, 2024 06:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment