New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use result<T&> in accessor functions #941

Draft

grisumbras wants to merge 6 commits into boostorg:develop from grisumbras:feature/use-result-ref

Member

grisumbras commented Sep 21, 2023

No description provided.

cppalliance-bot commented Sep 21, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

grisumbras force-pushed the feature/use-result-ref branch from 665f210 to 5c072f4 Compare

September 22, 2023 06:36

codecov bot commented Sep 22, 2023 •

edited

Codecov Report

Attention: Patch coverage is 77.11864% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 92.57%. Comparing base (dc95216) to head (c56d15f).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #941      +/-   ##
===========================================
- Coverage    93.11%   92.57%   -0.55%     
===========================================
  Files           87       87              
  Lines         8160     8292     +132     
===========================================
+ Hits          7598     7676      +78     
- Misses         562      616      +54

Files	Coverage Δ
include/boost/json/array.hpp	`100.00% <ø> (ø)`
include/boost/json/impl/array.hpp	`100.00% <100.00%> (ø)`
include/boost/json/impl/object.hpp	`100.00% <100.00%> (ø)`
include/boost/json/impl/pointer.ipp	`100.00% <100.00%> (ø)`
include/boost/json/impl/string.hpp	`98.52% <100.00%> (+0.06%)`	⬆️
include/boost/json/impl/value.hpp	`100.00% <100.00%> (ø)`
include/boost/json/object.hpp	`100.00% <ø> (ø)`
include/boost/json/string.hpp	`100.00% <ø> (ø)`
include/boost/json/value.hpp	`98.83% <100.00%> (-0.09%)`	⬇️
include/boost/json/impl/array.ipp	`98.42% <57.14%> (-1.58%)`	⬇️
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc95216...c56d15f. Read the comment docs.

cppalliance-bot commented Sep 22, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

grisumbras force-pushed the feature/use-result-ref branch from 5c072f4 to 0883729 Compare

September 23, 2023 15:03

cppalliance-bot commented Sep 23, 2023

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot commented Sep 23, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

cppalliance-bot commented Sep 24, 2023

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot commented Sep 24, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

grisumbras force-pushed the feature/use-result-ref branch from e4ff647 to 818be3e Compare

September 25, 2023 06:28

cppalliance-bot commented Sep 25, 2023

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot commented Sep 25, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

grisumbras force-pushed the feature/use-result-ref branch from 818be3e to a5d483e Compare

September 29, 2023 09:39

cppalliance-bot commented Sep 29, 2023

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot commented Sep 29, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

grisumbras force-pushed the feature/use-result-ref branch from a5d483e to 82d8637 Compare

September 30, 2023 05:09

cppalliance-bot commented Sep 30, 2023

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot commented Sep 30, 2023

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html


try_to_number

60bc701

grisumbras force-pushed the feature/use-result-ref branch from 82d8637 to 148770f Compare

May 13, 2024 13:54

cppalliance-bot commented May 13, 2024

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

grisumbras added 5 commits

May 13, 2024 17:55


try_at_pointer and try_set_at_pointer

3667f0c


try_as_ functions

00c721b


try_at functions

055b544


accessor functions have source_location parameters

8e7b6aa


fix grouped function docs

c56d15f

grisumbras force-pushed the feature/use-result-ref branch from 148770f to c56d15f Compare

May 13, 2024 17:15

cppalliance-bot commented May 13, 2024

An automated preview of the documentation is available at https://941.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

cppalliance-bot commented May 13, 2024

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/941/pullrequest.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment