Backwards compatibility #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed internal funciton: bool check_version(int major, int minor) const. - Created function: uint_ version_number() const version_number function computes and caches the OpenCL device version for faster runtime checks. * Aditional runtime version checks. Static linking checks are not enough: You can compile a funcition using a OpenCL 2.0 enabled system, but if the final device is only 1.2, only 1.2 functions must be invoked.
… You can compile a function using a OpenCL 2.0 enabled system, but if the final device is only 1.2, only 1.2 functions must be invoked. * Added enqueue_map_image functions. * enqueue_unmap_buffer uses memory_object instead of buffer objects, so it can be used with images. * Added static assets: BOOST_STATIC_ASSERT * Deprecated functions (eg. clEnqueueTask) must be compiled for backward compatibility. * Removed check_device_version
… You can compile a function using a OpenCL 2.0 enabled system, but if the final device is only 1.2, only 1.2 functions must be invoked. * Deprecated functions (eg. clCreateImage2D) must be maintained for backward compatibility.
…h other get_*() functions. * Added the get_version() member function to command_queue and to context for fast runtime checks. * Runtime checks. * More synchronizable functions in command_queue (enqueue_read_buffer_rect, enqueue_write_buffer_rect, enqueue_map_buffer, enqueue_map_image, enqueue_svm_map,...) * Fixed a bad use of `cl_bool blocking_read = CL_TRUE` when trying to use the returned event (enqueue_read_image, enqueue_write_image,...)
… to the first dimension size.
* XXX_async() functions wher returning event.
#include <boost/compute/interop/opengl/gl.hpp> #include <boost/compute/interop/opengl/cl_gl_ext.hpp> instead of: #ifdef __APPLE__ #include <OpenGL/gl.h> #include <OpenGL/glext.h> #else #include <GL/gl.h> #include <GL/glext.h> #endif * Created: enqueue_copy_buffer_async(), enqueue_copy_buffer_async(). * In Windows Inlude "windows.h" before <GL/gl>
|
Wow, thanks for making these fixes and doing all this work! It'll take me a few days to review and plan how to integrate these changes. Thanks! |
* Declare const those functions than does not modify class members (even if is modified the refered data). * Empty constructor for user_event.
channel_order get_channel_order() channel_data_type get_channel_data_type() const
Warning: Code under development
* changed enum device_type name
|
I doubt I'll be able to merge a such big pull-request. Maybe later I'll try to rebase your change to current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Kule.
This pull adds runtime version checking. It also normalizes the event system of command_queue. Also new enqueue_map_image function.