-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table list display #244
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like the UX of this change. If you have a few channels and a few timepoints you get heaps of result windows that will jam the window manager. Much better just to list to which volume each result refers in result columns, one column per hyperstack dimension.
e.g. this macro:
newImage("HyperStack", "8-bit composite-mode", 128, 128, 3, 128, 5);
run("Fractal dimension", "inputimage=net.imagej.ImgPlus@1a3f2fb1 startboxsize=32 smallestboxsize=6 scalefactor=1.2 translations=0 autoparam=true showpoints=true");
ce25b94
to
b2fcc64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better, but it will be harder than necessary to parse the outout as currently implemented:
HyperStack Channel: 3, Time: 2 | 0.0 | NaN
where |
is a column separator. Better for the user's later results handling to do this:
Image | Channel | Time | Fractal Dimension | R²
HyperStack | 3 | 2 | 0.0 | NaN
I had a good reason not to do it that way. IIRC sorting columns didn't quite work, i.e. results didn't "follow" their channels/frames. However, that is no longer the case. This fix will be bigger, and should be in another PR. I'm assuming for consistency's sake you want all the plugins to write their results in the way described above? @mdoube If you wouldn't mind adding an issue about it in the meanwhile? |
961e107
to
62a1605
Compare
Yes, that would be good for users. |
Co-authored-by: Michael Doube <[email protected]>
Fixes a bug where
FractalDimensionWrapper
would display only one point table instead of one for each 3D subspace in a hyper stack.