Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a couple proposed changes from reviewing this code, was easiest to just edit locally and send a PR. feel free to keep or drop anything here.
other review notes:
Do we need to do the blob sync stuff at all in BGS? not sure that is in-scope. maybe it is disabled by not configuring when deployed, but could just rip the code out also.
As a high-level thing, many error cases result in
err
getting returned, but I believe we just log and move on. Maybe event processing should have multiple high-level results:kind of an architecture philosophy thing and maybe you want to stick with the current system (pros/cons), but as we firm up all the possible validation error cases a framework like the above might be helpful.