remove deprecated com.atproto.sync endpoints (getHead and getCheckout) #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of breaking up #2376 in to smaller easier-to-merge chunks.
Removes
com.atproto.sync.getHeadandcom.atproto.sync.getCheckout. These have been marked as deprecated for a long time (in Lexicons), and moved in to a separate "deprecated" namespace (in the TS API). I don't see any remaining calls in this repo or insocial-app. I searched our prod logs for calls to these endpoints, and the only calls I see from the last week are from our openapi endpoint doc generation CI script, which calls all endpoints to check if they require auth or not.