fix(crypto): Add KeypairOptions for fixing tests #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugyan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that only
.toBeTruthyis written (no parentheses) and not tested incrypto/tests/did.test.ts: it seems to be the only two places in this repository.After adding the parentheses and running the test, the test failed. This seems to be because
did.parseDidKeycallsdecompressPubkeyand returns 65-byte keyBytes, whilegetPublicKeyin@noble/curvesgenerates 33-byte compressed signatures by default.https://github.com/paulmillr/noble-curves?tab=readme-ov-file#upgrading
If the intended behavior is for
parseDidKeyto return a decompressed version, then the publicKey to be compared in the test needs to be generated withisCompressed: false. So, I modified it to add an argument in each plugins.