PDS: Enable to specify name of email sender. #2369
Open
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While nodemailer can parse address with formatted-name such as "John [email protected]", the name part must be enclosed in double quotes if special symbols are contained. That may be complicated because we pass the address via an environment variables to PDS. This commit enables to specify the name of the sender by adding configurable points with backward compatibility.
|
@devinivy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While nodemailer can parse address with formatted-name such as "
John <[email protected]>", the name part must be enclosed in double quotes if special symbols are contained.That may be complicated because we pass the address via an environment variable to PDS.
This PR enables to specify the name of the sender by adding configurable points with backward compatibility.