Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Don't require skip-news if NEWS.rst changes #690

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

godlygeek
Copy link
Contributor

Until now we've been requiring every PR affect a file in the news/ directory or be labeled with skip-news. Also allow a PR to directly touch NEWS.rst instead.

Until now we've been requiring every PR affect a file in the news/
directory or be labeled with `skip-news`. Also allow a PR to directly
touch NEWS.rst instead.

Signed-off-by: Matt Wozniski <[email protected]>
@godlygeek godlygeek self-assigned this Oct 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (457365a) to head (03ffe8a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   92.91%   92.89%   -0.02%     
==========================================
  Files          95       95              
  Lines       11475    11475              
  Branches     2114     2114              
==========================================
- Hits        10662    10660       -2     
- Misses        813      815       +2     
Flag Coverage Δ
cpp 92.89% <ø> (-0.02%) ⬇️
python_and_cython 92.89% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablogsal pablogsal merged commit df48806 into bloomberg:main Oct 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants