Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle changes in Textual 0.48 #543

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Handle changes in Textual 0.48 #543

merged 4 commits into from
Feb 5, 2024

Commits on Feb 2, 2024

  1. Use a CSS file for the tree reporter's style rules 

    Previously we were declaring these styles in the Python source code, but
moving them into a dedicated `.css` file allows hot reloading to work
when using `textual run --dev`, and causes the rules to take effect in
some situations when they otherwise would be ignored or overridden.

Signed-off-by: Matt Wozniski <[email protected]>
    @godlygeek
    godlygeek committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    e36f315 View commit details
    Browse the repository at this point in the history

  2. tree: Disable soft wrapping for textual TextArea 

    Textual 0.48 introduces a breaking change for the `TextArea` widget:
line wrapping is now enabled by default. Since we don't want line
wrapping, we need to disable that. We can do so by simply assigning
`False` to the `soft_wrap` reactive property. Older versions of Textual
don't have that property, but they totally ignore this assignment, so
assigning this doesn't affect backwards compatibility.

Signed-off-by: Matt Wozniski <[email protected]>
    @godlygeek
    godlygeek committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    fc8e0c8 View commit details
    Browse the repository at this point in the history

  3. tests: Update snapshots for Textual 0.48 

    The snapshot diff shows that the only difference is a slight change to
the rendering of some of the characters in the capture, rather than
anything our users would be able to observe.

Signed-off-by: Matt Wozniski <[email protected]>
    @godlygeek
    godlygeek committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    353a4f1 View commit details
    Browse the repository at this point in the history

  4. tests: Skip some snapshot tests on Python 3.7 

    The latest versions of Textual only support Python 3.8 and higher, so
differences from the snapshot are expected when running Python 3.7.

Signed-off-by: Matt Wozniski <[email protected]>
    @godlygeek
    godlygeek committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    88fbf58 View commit details
    Browse the repository at this point in the history