Disable leaks warning if tracing Python allocators #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture this in the capture file header, and thread it through to the metadata included in generated reports. Signed-off-by: Matt Wozniski <[email protected]>
We warn when generating a leaks report when pymalloc is in use, because the memory held by pymalloc would appear to us as a leak when it has actually just been set aside for future use. But, when `--trace-python-allocators` is used, we do have visibility into whether the memory has set aside for future use, and so we don't need to show this warning in that case. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
hide_leaks_warning_if_trace_python_allocators
branch
from
c910b99
to
8fc1e5c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
- Coverage 92.28% 92.18% -0.11%
==========================================
Files 91 91
Lines 10849 10872 +23
Branches 1498 1499 +1
==========================================
+ Hits 10012 10022 +10
- Misses 835 847 +12
- Partials 2 3 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pablogsal
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We warn when generating a leaks report when pymalloc is in use, because
the memory held by pymalloc would appear to us as a leak when it has
actually just been set aside for future use.
But, when
--trace-python-allocatorsis used, we do have visibilityinto whether the memory has set aside for future use, and so we don't
need to show this warning in that case.