Avoid creating more backtrace_state* than needed
#473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having a `StringStorage` class which exposes a custom identifier used as a token for resolving an interned string, expose an `InternedString` type directly constructible from a `std::string`. This type handles the interning automatically, and using this type in signatures allows us to encode whether a particular function needs to be called with an interned string or could be called with any string. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
fix_unwind_leak
branch
from
3e8b4d5
to
b85885c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 91.99% 91.96% -0.03%
==========================================
Files 91 91
Lines 10803 10807 +4
Branches 1485 1485
==========================================
+ Hits 9938 9939 +1
- Misses 863 866 +3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
`libbacktrace` gives us no way to free a `backtrace_state*` once it's been created, so it's in our best interest to create as few of them as possible. Rather than having one cache of `backtrace_state*` per opened capture file, have a global cache of `backtrace_state*` (protected by a global mutex). Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
fix_unwind_leak
branch
from
b85885c
to
8b30350
Compare
pablogsal
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libbacktracegives us no way to free abacktrace_state*once it'sbeen created, so it's in our best interest to create as few of them as
possible. Rather than having one cache of
backtrace_state*per openedcapture file, have a global cache of
backtrace_state*(protected bya global mutex).
Closes: #472