Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker): Add support for configuring docker host settings #575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Porsh33
Copy link
Contributor

@Porsh33 Porsh33 commented Nov 8, 2022

Reference to docker/for-linux#321 currently where are no way to use FUSE fs in docker container. Official manual (see one above) recommend to run container with --cap-add and --device options.

This PR add support some new Docker host options in worker config:

  • --docker-addcaps -- Values to bypass docker run --cap-add=<value>
  • --docker-mounts -- Global mount points. Very useful to prevent write docker.sock mount point for each builds
  • --docker-devices -- Device redirection. Useful to redirect /dev/* into container. Need to works with fuse fs
  • --docker-privileged -- Run build container in privileged mode. Bool, default False

All string options allow multiple choices. E.g.

abstruse-worker --docker-mounts "/var/log:/var/log" --docker-mounts "/tmp:/tmp"

@Porsh33
Copy link
Contributor Author

Porsh33 commented Nov 8, 2022

Perhaps it's also worth adding support global ENV variables?

UPD. Found this issue: #496 I think i'll do it in separate PR

@Porsh33 Porsh33 mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant