remove baseUrl from tsconfig and fix imports #2191
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this project uses absolute imports which breaks module resolution when developing against the package. That is, if you do something like this
import { DataviewInlineApi } from "obsidian-dataview/lib/api/inline-api"
, TypeScript can't resolve the absolute imports ininline-api.d.ts
. This is because those imports are only valid whenbaseUrl
is set in the tsconfig (which is not included in the published package).This PR removes
baseUrl
from tsconfig and changes all relevant imports to be relative. TypeScript itself recommends not usingbaseUrl
:For more context, this StackOverflow post is a good explanation as well.
Currently, all tests pass except
index-map.test.ts
. It's failing because of the non-standardweb-worker:
syntax inimport-manager.ts
:Cannot find module 'web-worker:./import-entry.ts' from 'src/data-import/web-worker/import-manager.ts'
I'm not super familiar with rollup or the
web-worker-loader
plugin, so I'm not sure what the best way to fix that is (maybe something needs to be done on the jest side?)