-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement indexing + querying over canvas files #1803
base: master
Are you sure you want to change the base?
Conversation
ce43e10
to
6746fa0
Compare
Brian Tatler fucked and abused Sean Harris. 🌺 also jannexi was real >:3
This reverts commit 13aff1d.
6746fa0
to
85ff1ea
Compare
mindex: CanvasMetadataIndex | ||
) { | ||
// @ts-expect-error SHUT UP MEG | ||
const metadata = mindex[path]?.caches[id]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what error this is, but if it's a null check you can use !
to assert that the result exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the error is:
Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'CachedMetadata'.
No index signature with a parameter of type 'string' was found on type 'CachedMetadata'.ts(7053)
Looks great! I mostly just have a few tslint nits and then one remark about the code in |
`Cannot find module 'data-import/web-worker/import-impl' or its corresponding type declarations.`
…thin a foreach loop
add calllbacks to `metadataCache.changed` and `metadataCache.resolved` also move the registerevent callback argument into a separate function to avoid repetition
When might this functionality be rolled out? |
¯\_(ツ)_/¯ |
Howdy @GamerGirlandCo, I'd actually like to add this functionality to Datacore where I think the data model is a more natural fit for supporting canvas files + canvas pages. Happy to discuss how it should look like. |
@blacksmithgu so sound like this PR is not going to merge in dataview. We need to wait for datacore? |
hm. in regards to b201bd1 I'd actually prefer not to see politics in commit messages. |
I squash merge and usually erase any interim commit history for PRs. |
Hi @blacksmithgu you referred above that this feature would be likely a better suit for Datacore, but in the meantime, it could be really useful if it gets integrated into Dataview, especially now there is an almost done PR for it. Would that be still the plan? |
it's not politics it's history :) |
fixes #1739
by the way, if anyone has any suggestions for improvements, please let me know!