Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index .canvas files #1739

Open
sohanglal opened this issue Jan 6, 2023 · 5 comments · May be fixed by #1803
Open

Index .canvas files #1739

sohanglal opened this issue Jan 6, 2023 · 5 comments · May be fixed by #1803
Assignees
@blacksmithgu
Labels
feature-request New feature or request.

Comments

@sohanglal
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Feature to index canvas files just like markdown files. This will enable querying over inline fields defined in canvas files

Describe alternatives you've considered
Searched through the existing issues and discussions, couldn't find any thread suggesting the same.
@sohanglal sohanglal added the feature-request New feature or request. label Jan 6, 2023
@AB1908
Copy link
Collaborator

AB1908 commented Jan 6, 2023

Do you want to try implementing this?

@sohanglal
Copy link
Contributor Author

I lack the skills to do the same

@sohanglal
Copy link
Contributor Author

@GamerGirlandCo would it be possible for you to implement this feature?

PR #1661 fixing issue #1655 is working extremely well! Thanks!

@GamerGirlandCo
Copy link
Collaborator

GamerGirlandCo commented Feb 12, 2023 •
edited
Loading

@GamerGirlandCo would it be possible for you to implement this feature?

PR #1661 fixing issue #1655 is working extremely well! Thanks!

okay so, i've attempted to implement this, and it's simply not possible due to obsidian excluding the contents of canvas files from its internal metadataCache, which dataview heavily relies on. i'm sorry.

turns out there is a cache for canvas file contents, just stored in the instance of the canvas core plugin. and i managed to find a way to access it :D

@sohanglal
Copy link
Contributor Author

@GamerGirlandCo would it be possible for you to implement this feature?
PR #1661 fixing issue #1655 is working extremely well! Thanks!

okay so, i've attempted to implement this, and it's simply not possible due to obsidian excluding the contents of canvas files from its internal metadataCache, which dataview heavily relies on. i'm sorry.

turns out there is a cache for canvas file contents, just stored in the instance of the canvas core plugin. and i managed to find a way to access it :D

That's amazing! 🥳

@GamerGirlandCo GamerGirlandCo linked a pull request Feb 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blacksmithgu blacksmithgu

Labels
feature-request New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement indexing + querying over canvas files GamerGirlandCo/obsidian-dataview
4 participants
@blacksmithgu @AB1908 @sohanglal @GamerGirlandCo