Config Integration and Features #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code reviewed config and unit test and didn't find any issues there |
| @@ -19,7 +20,7 @@ | |||
| /** | |||
| * The size of an overlay address, in bytes. | |||
| */ | |||
| public static final int DEFAULT_ADDRESS_SIZE = 16; | |||
| public static final int DEFAULT_ADDRESS_SIZE = (int) ConfigReadOnly.get("default.config", "default_address_size"); | |||
There was a problem hiding this comment.
there has to be a better design pattern for this.
There was a problem hiding this comment.
just a static method getReadOnly in the regular config class?
+added default.config file, where the node can be configured to run from. +Node Populates from configurations +Config now has a "ReadOnly" functionality so it can be used when a node does not exist. +Keys are now standarized when get, put, and load are called. This keeps things consistent. +Integration with other classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+added default.config file, where the node can be configured to run from.
+Node Populates from configurations
+Config now has a "ReadOnly" functionality so it can be used when a node does not exist.
+Keys are now standarized when get, put, and load are called. This keeps things consistent.
+Some integration with other classes, but needs to be fleshed out more will bring this up at the meeting.
Addresses #36 and #30