[bitnami/airflow] bugfix: extra volume/mounts should apply to setup-db job and wait-for-db init-container #30646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b job and wait-for-db init-container Signed-off-by: juan131 <[email protected]>
github-actions
bot
added
airflow
verify
Signed-off-by: Bitnami Containers <[email protected]>
migruiz4
approved these changes
Nov 27, 2024
javsalgar
approved these changes
Nov 27, 2024
javsalgar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR ensures the
extraVolumeMountsandextraVolumesparameters are considered also for the setup-db k8s job and the wait-for-db init container.Benefits
Users that use a external database with TLS encryption enabled setting a custom SQL connection string via the
externalDatabase.sqlConnectionparameters might need to useextraVolumeMountsandextraVolumesparameters to mount the TLS client certs. If that't the case, it's needed to mount them on setup-db k8s job and the wait-for-db init container too.Possible drawbacks
None
Applicable issues
None
Additional information
N/A
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.