[bitnami/redis] add extraPortsEnabled #30607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shecodesmagic
force-pushed
the
headless-extraPorts-add
branch
from
9dd50bc
to
022234e
Compare
Signed-off-by: Sepideh Alavi <[email protected]> [bitnami/redis] add extraPortsEnabled Signed-off-by: Sepideh Alavi <[email protected]>
shecodesmagic
force-pushed
the
headless-extraPorts-add
branch
from
022234e
to
8ddf5ad
Compare
Signed-off-by: Bitnami Containers <[email protected]>
javsalgar
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
dgomezleon
requested changes
Nov 25, 2024
Comment on lines
+2253
to
+2265
| ## @section service configuration parameters | ||
| ## | ||
| service: | ||
| headless: | ||
| ## @param service.headless.extraPorts Optionally specify extra ports to expose for the headless service. | ||
| ## Example: | ||
| ## extraPorts: | ||
| ## - name: my-custom-port | ||
| ## port: 12345 | ||
| ## protocol: TCP | ||
| ## targetPort: 12345 | ||
| ## | ||
| extraPorts: [] |
There was a problem hiding this comment.
Section service.headless already exists. Please place this code there (L1462)
Comment on lines
+36
to
+41
| {{- range .Values.service.headless.extraPorts }} | ||
| - name: "{{ .name }}" | ||
| port: {{ .port }} | ||
| protocol: "{{ .protocol | default "TCP" }}" | ||
| targetPort: {{ .targetPort | default .port }} | ||
| {{- end }} |
There was a problem hiding this comment.
Suggested change
| {{- range .Values.service.headless.extraPorts }} | |
| - name: "{{ .name }}" | |
| port: {{ .port }} | |
| protocol: "{{ .protocol | default "TCP" }}" | |
| targetPort: {{ .targetPort | default .port }} | |
| {{- end }} | |
| {{- include "common.tplvalues.render" (dict "value" .Values.service.headless.extraPorts "context" $) | nindent 4 }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change introduces an optional parameter service.headless.extraPorts, allowing users to specify extra ports to be exposed on the headless service. Users can define additional ports (e.g., for metrics or custom services) directly under service.headless.extraPorts.
Benefits
Users can expose additional ports via the headless service for better integration, monitoring, or custom functionality. They can add extra ports without the need for additional enabling flags; simply defining service.headless.extraPorts is sufficient.
Moreover, existing deployments remain unaffected unless users choose to utilize the new extraPorts parameter.
Possible drawbacks
None known.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm