Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/sealed-secrets] Fix namespace in PodDisruptionBudget #30453

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BWagenerGenerali
Copy link
Contributor

Description of the change

Currently the PodDisruptionBudget in the sealed-secret chart is deployed to the release namespace. This however, is not necessarily the namespace the rest of the sealed-secrets manifests are deployed to (i.e. due to .Values.namespaceOverride being set).

That leads to a violated PodDisruptionBudget in the release namespace, as the pods it references are deployed to a different namespace.

This PR updates the namespace field in the PDB to have the same value as for example the deployment it references:

Benefits

Setting .Values.namespaceOverride no longer breaks the PDB.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

Signed-off-by: Bitnami Containers <[email protected]>
@BWagenerGenerali
Copy link
Contributor Author

Hi @carrodher,

it seems I was missing a newline before the sign-off section. It should be fixed now.

@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Nov 18, 2024
@github-actions github-actions bot removed the triage Triage is needed label Nov 18, 2024
@github-actions github-actions bot removed the request for review from carrodher November 18, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress sealed-secrets verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants