[bitnami/etcd] PDB review #25896
Merged
[bitnami/etcd] PDB review #25896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fran Mulero <[email protected]>
jotamartos
approved these changes
May 15, 2024
toobster
pushed a commit
to toobster/charts
that referenced
this pull request
May 15, 2024
Signed-off-by: Fran Mulero <[email protected]> Signed-off-by: Tobias Schneeberger <[email protected]>
fmulero
added a commit
that referenced
this pull request
May 17, 2024
* [bitnami/etcd] PDB review Signed-off-by: Fran Mulero <[email protected]> * [bitnami/etcd] Revert previous changes in PDB Signed-off-by: Fran Mulero <[email protected]> * Re-apply changes Signed-off-by: Fran Mulero <[email protected]> --------- Signed-off-by: Fran Mulero <[email protected]>
fmulero
added a commit
to fmulero/charts
that referenced
this pull request
May 22, 2024
* [bitnami/etcd] PDB review Signed-off-by: Fran Mulero <[email protected]> * [bitnami/etcd] Revert previous changes in PDB Signed-off-by: Fran Mulero <[email protected]> * Re-apply changes Signed-off-by: Fran Mulero <[email protected]> --------- Signed-off-by: Fran Mulero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Little fixes in PodDisruptionBudget configuration to keep it aligned with current templates.
Benefits
Keep our charts up to date according to our templates
Possible drawbacks
None
Adition information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm