Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/grafana-loki] Allow disabling enableServiceLinks #25858

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bpfoster
Copy link
Contributor

@bpfoster bpfoster commented May 14, 2024

Description of the change

Some other charts allow configuring whether service links are enabled or not. This PR will allow disabling service links individually on all the loki workloads. By default, service links are enabled, so there is no change to existing behavior.

Benefits

Users can disable service links. If they have a lot of workloads, there may be a lot of environment variables populated which are not used.

Possible drawbacks

None to my knowledge.

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added grafana-loki triage Triage is needed labels May 14, 2024
@github-actions github-actions bot requested a review from carrodher May 14, 2024 13:08
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 14, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 14, 2024
@github-actions github-actions bot removed the request for review from carrodher May 14, 2024 14:03
@github-actions github-actions bot requested a review from alemorcuq May 14, 2024 14:03
@bpfoster
Copy link
Contributor Author

I think the test failure here is unrelated. I randomly get a goss failure on both this commit and the one prior.

alemorcuq
alemorcuq previously approved these changes May 20, 2024
Copy link
Member

@alemorcuq alemorcuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grafana-loki in-progress verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants