Use req.originalUrl instead of req.url for logs and don't manipulate req.url #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation overwrites
req.url
since it is used in the log message templates.This leads to errors and issues like #156. In our case, it makes the Express app even crash.
This PR removes the overwrite of
req.url
and switches toreq.originalUrl
for the log messages.It resolves #156.
A little bit more context:
The Express docs explain that
req.url
should only be changed for explicit desired internal routing purposes.