feat: add hybrid cjs-esm support #53
Conversation
|
I've tested out the other commands and they work fine too, @junderw can you have a look? |
|
Could you convert the existing travis CI config to Github Actions CI so I can run the tests and lints on this? Thanks. |
|
Hey! The devDependency I used to run ts files, i.e. I've tried instead to run tests on two different builds without tsx but that requires you to change the way imports are done on both the files (which can't be done as they're built from the same source so you can't get two different outputs). One suggestion would be to just test on one build and stick with that, however I'd like your opinion on this before I move ahead |
|
Testing one build should be fine |
chore: rm log chore: run ci on all pushes fix: ci
src/test/index.ts
Outdated
| @@ -96,19 +105,19 @@ fixtures.bech32.valid.forEach((f: Fixture): void => { | |||
| testValidFixture(f, bech32Lib.bech32); | |||
| }); | |||
|
|
|||
| fixtures.bech32.invalid.forEach((f: InvalidFixture): void => { | |||
| ((fixtures.bech32.invalid as unknown) as InvalidFixture[]).forEach((f: InvalidFixture): void => { | |||
There was a problem hiding this comment.
I think TypeScript has a method of importing JSON files and automatically discerning the type at compile time... could you look into that?
We discussed this in the stream but are you happy with the way tests are being done right now? Currently they're being run from the source itself. This prevents build files from getting into the bundle but I can revert to testing both of them individually as well.
TODO: Have to change the other commands as well apart from
buildandtest