ci: add markdown link check job #30034
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
|
Without #30025 (or alternative fix) the new action being added here will fail. |
willcl-ark
force-pushed
the
link-check-action
branch
from
80d166b
to
b6be80c
Compare
willcl-ark
force-pushed
the
link-check-action
branch
from
b6be80c
to
ffc691a
Compare
|
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the Possibly this is due to a silent merge conflict (the changes in this pull request being Leave a comment here, if you need help tracking down a confusing failure. |
willcl-ark
force-pushed
the
link-check-action
branch
from
ffc691a
to
961a536
Compare
willcl-ark
force-pushed
the
link-check-action
branch
from
961a536
to
9d2a8a8
Compare
|
utACK 9d2a8a8 with or without the nits |
This adds a markdown hyperlink check task to the lint test_runner. It relies on having the [`mlc`](https://crates.io/crates/mlc) binary found on $PATH, but will fail with `success` if the binary is not found. `mlc` is also added to the ci/04_install.sh script run by the containerfile. Note that broken markdown hyperlinks will be detected in untracked markdown files found in a dirty working directory (including e.g. .venv).
willcl-ark
force-pushed
the
link-check-action
branch
from
9d2a8a8
to
82c5f95
Compare
|
Thanks @maflcko , did a final force-push for that silly nit: Sorry to invalidate the ACK |
|
utACK 82c5f95 Thanks! |
Potential followup to: #30025
This should prevent us reintroducing broken markdown links.
It does not test "online" (external) links, only those within this repo. Both relative and absolute links are parsed successfully if they resolve.