Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: index TxOrphanage by wtxid, allow entries with same txid #30000

Merged
merged 7 commits into from
May 15, 2024
Merged

p2p: index TxOrphanage by wtxid, allow entries with same txid #30000

merged 7 commits into from
May 15, 2024

Commits on May 14, 2024

  1. [p2p] don't query orphanage by txid

    @glozow
    glozow committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7e475b9 View commit details
    Browse the repository at this point in the history

  2. [refactor] TxOrphanage::HaveTx only by wtxid

    @glozow
    glozow committed May 14, 2024
    Configuration menu
    Copy the full SHA
    efcc593 View commit details
    Browse the repository at this point in the history

  3. [refactor] TxOrphanage::EraseTx by wtxid 

    No behavior change right now, as transactions in the orphanage are
unique by txid. This makes the next commit easier to review.
    @glozow
    glozow committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c31f148 View commit details
    Browse the repository at this point in the history

  4. [p2p] allow entries with the same txid in TxOrphanage 

    Index by wtxid instead of txid to allow entries with the same txid but
different witnesses in orphanage. This prevents an attacker from
blocking a transaction from entering the orphanage by sending a mutated
version of it.
    @glozow
    glozow committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8923edf View commit details
    Browse the repository at this point in the history

  5. [unit test] TxOrphanage handling of same-txid-different-witness txns

    @glozow
    glozow committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6675f64 View commit details
    Browse the repository at this point in the history

  6. [functional test] attackers sending mutated orphans

    @glozow
    glozow committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b16da7e View commit details
    Browse the repository at this point in the history

  7. [log] updates in TxOrphanage 

    - Add elapsed time in "remove orphan" log
- Add size in "stored orphan" log
- grammar edit
    @glozow
    glozow committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0fb17bf View commit details
    Browse the repository at this point in the history