Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule and test against BCHN, expand VMB test coverage #148

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

bitjson
Copy link
Member

@bitjson bitjson commented Nov 15, 2024

No description provided.

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 76879be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bitauth/libauth Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 46.98795% with 176 lines in your changes missing coverage. Please review.

Project coverage is 94.34%. Comparing base (cad78dd) to head (76879be).
Report is 7 commits behind head on next.

Files with missing lines Patch % Lines
...truction-sets/bch/2023/bch-2023-instruction-set.ts 21.60% 97 Missing and 1 partial ⚠️
...ib/vm/instruction-sets/bch/2023/bch-2023-tokens.ts 14.63% 35 Missing ⚠️
src/lib/vmb-tests/bch-vmb-test-utils.ts 73.68% 20 Missing ⚠️
src/lib/vm/instruction-sets/common/crypto.ts 0.00% 8 Missing ⚠️
...truction-sets/bch/2025/bch-2025-instruction-set.ts 36.36% 7 Missing ⚠️
src/lib/vm/instruction-sets/common/stack.ts 66.66% 5 Missing ⚠️
src/lib/language/reduce.ts 33.33% 2 Missing ⚠️
src/lib/vm/instruction-sets/common/push.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #148      +/-   ##
==========================================
- Coverage   97.84%   94.34%   -3.50%     
==========================================
  Files         156      156              
  Lines       52750    52985     +235     
  Branches     1957     1616     -341     
==========================================
- Hits        51611    49989    -1622     
- Misses       1139     2995    +1856     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitjson bitjson merged commit 1ae893c into next Nov 15, 2024
20 of 30 checks passed
@github-actions github-actions bot mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant