fix(gui): Rephrase restore-config message dialog #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
added
Qt
aryoda
requested changes
May 6, 2024
buhtz
added
PR: Modifications requested
|
I modified your suggestion being more "indirect" and not talking directly to the users via "you". Rephrased the message box:
Rephrased the hint text about how to find a config. Using monotype for the path. Improved source strings with respect to translators. Used a new title for that window.
|
buhtz
added
PR: Merge after creative-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dialog message bothered me every time I saw it. Users installing BIT, running it for the first time and then they got such a message in the beginning and it feels like that BIT is broken.
That is why I tried to rephrase it a bit to make it not sounding so alarming. On the long run it might be better to have a nice looking window with two big buttons (Restore config & Start from scratch/empty config).
Before:
After:
Qt6 migration related AttributeError
I again found an AttributeError related to the Qt6 migration. And after rummaging around in my head I remembered the Issue #1680 which is about this problem. PyLint is not able to find such errors because of specific characteristics in the Qt6 library. My question to PyLint devs is still pending. I was using grep heavily but still was not able to found every problem. 馃槶
Fix #1680