build(deps): upgrade syn crate #2671
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless there are significant build time gains, I think this isn't needed for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to Syn 2.x.
This brings many breaking changes. This is a painful migration.
For now, I still encounter some issue and as usual debugging macros is so hard...
It is no longer possible to use a keyword as an identifier in attributes.
Thus, I renamed
typeintouse_typefor the partial attribute.I also tried to use the more idiomatic way of writting attribute parsing.
I used teh provded methods for error reporting.
However this seems still very cryptic and unhelpful when something wrong happen.
I still don't understand how to improve error reporting for macros...
Test Plan
CI must pass.