Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_js_analyzer): useJsxSortProps #2652

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

vohoanglong0107
Copy link
Contributor

Summary

Implement Eslint's lint rule [jsx-sort-props](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md]

Test Plan

All tests should pass

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Apr 30, 2024
Copy link

codspeed-hq bot commented Apr 30, 2024

CodSpeed Performance Report

Merging #2652 will not alter performance

Comparing vohoanglong0107:feat-use-jsx-sort-props (d90a4b6) with main (2c70d3f)

Summary

✅ 84 untouched benchmarks

@github-actions github-actions bot added the A-CLI Area: CLI label Apr 30, 2024
@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review April 30, 2024 13:41
@ematipico
Copy link
Member

I'm not very fond of having stylistic rules inside our linter. I think this rule should be an assist.

I was working on a similar rule for sorting JSON keys, and setting up the foundations for assists inside the CLI and LSP.

@vohoanglong0107
Copy link
Contributor Author

Oh ok, then I will set this PR to draft for the time being

@vohoanglong0107 vohoanglong0107 marked this pull request as draft May 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants