Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gfaviz #52752

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add gfaviz #52752

wants to merge 10 commits into from

Conversation

pbordron
Copy link
Contributor

Add gfaviz for linux and osx (not tested on osx-arm64)


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.


build:
number: 0
skip: True # [ windows ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need. Windows is not supported anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it from recipe

recipes/gfaviz/meta.yaml Show resolved Hide resolved
@pbordron
Copy link
Contributor Author

pbordron commented Dec 12, 2024

Does someone has a clue about how to a test a QT software asking for display ? @bioconda/core

If I try to run gfaviz --help or gfaviz --no-gui as test, I get the following error.

10:20:45 BIOCONDA INFO (OUT) + gfaviz --help
10:20:45 BIOCONDA INFO (OUT) Warning: could not connect to display
10:20:45 BIOCONDA INFO (OUT) Info: Could not load the Qt platform plugin "xcb" in "" even though it was found.
10:20:45 BIOCONDA INFO (OUT) Fatal error: This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
10:20:45 BIOCONDA INFO (OUT) 
10:20:45 BIOCONDA INFO (OUT) Available platform plugins are: eglfs, minimal, minimalegl, offscreen, vnc, webgl, xcb.
10:20:45 BIOCONDA INFO (OUT) 
10:20:46 BIOCONDA INFO (OUT) /opt/conda/conda-bld/gfaviz_1733994848890/test_tmp/run_test.sh: line 8:  1137 Aborted                 (core dumped) gfaviz --help

@martin-g
Copy link
Contributor

Try with: - DISPLAY=:0.0 gfaviz --help

test:
commands:
- which gfaviz
# - gfaviz --help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# - gfaviz --help
- DISPLAY=:0.0 gfaviz --help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank for the clue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!
But now it fails to connect to it ...
I'll try to find other recipes that do something similar.
You can also remove this test and test the produced binary locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, must be an headless ci. It was successful on my computer with bioconda-utils build --docker --mulled-test --git-range master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas how to make xvfb-run works with ci/cd?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martin-g but it doesn't help.
The problem is that no xvfb-run nor Xvfb is found even if I use the right package according to https://conda-metadata-app.streamlit.app
Any idea ?

@pbordron
Copy link
Contributor Author

pbordron commented Dec 12, 2024

Someone can help me to solve the build failure for OSX? ping @bioconda/core

CI doesn't produce usefull logs and build succeed on my OSX 13 VM with bioconda-utils build recipes config.yml --git-range master command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants