Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UCSC recipes #37618

Closed
wants to merge 9 commits into from
Closed

Update UCSC recipes #37618

wants to merge 9 commits into from

Conversation

siebrenf
Copy link
Contributor

@siebrenf siebrenf commented Oct 25, 2022

The UCSC tools occasionally throw errors that should have been fixed ages ago (example1, example2). So I thought I'd try to update the recipes first.

breakdown:

  • updated ucsc_config.yaml
  • updated create-ucsc-packages.py
    • several packages have been fixed on UCSC's side and can now use the default build system
    • extended summary_program checking code
  • updated the UCSC patch
    • use shared libssl and libcrypto libraries
    • fixed straw compilation
  • updated all (template) recipes
    • added build dependency make as added manually in previous Bulk PRs
    • added build dependencies for straw (cxx + binutils to export Conda's ld command) as it is built for every package
    • left in the OSX build skip
    • removed unused run_test.sh scripts

The skeletons should now be up to date again. Errors are likely due to individual recipes breaking.


Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@siebrenf
Copy link
Contributor Author

@bioconda/core, I'm pinging you directly because of the size of this PR (it might have to point to the bulk branch).

This PR should now be in a decent state (I tested a handful of recipes using the standard build system, plus one recipe of each custom build systems, with bioconda-utils build locally).

@mbargull
Copy link
Member

@siebrenf, thanks a bunch!

  • ... manually in previous Bulk PRs

Haha, yeah I remember, in 2020 I fixed some hundreds recipes semi-automatically and the UCSC ones were a part of it -- guess during that busywork I never got to modify the templates accordingly 🤦 . Thanks for rectifying that! :).


I'd like to review this, but will probably not get to it in the next two weeks or so. After the review e should then build this on bulk. But the bulk branch will also be busy with the upcoming Bioconductor update during that time frame, so hopefully my pending review will not delay this too much.

Thanks again for working on this and also for detailing your changes.

@mbargull
Copy link
Member

Hi @siebrenf, I'll be reviewing this today/tomorrow so we can proceed and build all of v439 probably this week.

@aliciaaevans
Copy link
Contributor

Closing in favor of #50325 which has been merged and used to bulk update. If you think there are any improvements to the scripts that are on this branch that the other one missed, please let me know and/or open a fresh PR without recipe changes.

Sorry this never ended up getting approved, I am just finding it now when searching for old UCSC PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants