Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Downloads by Platform plots #8

Merged
merged 10 commits into from
Jul 31, 2024
Merged

feat: Downloads by Platform plots #8

merged 10 commits into from
Jul 31, 2024

Conversation

aliciaaevans
Copy link
Contributor

@aliciaaevans aliciaaevans commented Jul 31, 2024

A stacked bar plot showing downloads by os/arch. Once this is merged, I'll update bioconda-docs to add this to each package page.

Open to suggestions for color scheme if people associate certain colors by os (noarch gray?). This is just the default palette.

Example with fake data: (UPDATED)
visualization1

@aliciaaevans aliciaaevans requested review from mbargull and daler July 31, 2024 19:35
Copy link
Member

@epruesse epruesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice :-)

Leaving approval to the others since I've been a bit inactive for a ... few years.

src/build_plots/common.py Outdated Show resolved Hide resolved
src/build_plots/common.py Outdated Show resolved Hide resolved
src/build_plots/common.py Outdated Show resolved Hide resolved
src/build_plots/common.py Outdated Show resolved Hide resolved
@daler
Copy link
Member

daler commented Jul 31, 2024

Looks good. On one hand it might be interesting to split versions by platform, but I'm not sure we need that level of detail here.

I don't have any immediate preferences on colors. However, it would be good to be consistent across packages (e.g., osx-64 is always red, even if there aren't any linux packages).

And @epruesse I hope this means you are back in the game!?

@aliciaaevans
Copy link
Contributor Author

@daler I updated the color scheme (and example in the PR description) to a paired palette with fixed colors for each platform. The only down side is that if we add more platforms we'll have to update the array, but that would have to be done across all the repos anyway.

@aliciaaevans aliciaaevans merged commit d8709eb into main Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants