Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitlash.h #33

Closed
wants to merge 1 commit into from
Closed

Update bitlash.h #33

wants to merge 1 commit into from

Conversation

murilopontes
Copy link
Contributor

fix warning bitlash/src/bitlash.h:134:0: warning: "prog_uchar" redefined [enabled by default]

fix warning bitlash/src/bitlash.h:134:0: warning: "prog_uchar" redefined [enabled by default]
@matthijskooijman
Copy link

Hmm, doesn't removing those defines from the arm build break the arm build?

Also, I have a fairly thoroug restructure of things coming up in #31, which will also fix this particular warning (as well as a bunch of others). It would be easier to just wait for that series to be completed, if we merge this pullrequest I'll have to update a dozen patches in my series, I think.

@murilopontes
Copy link
Contributor Author

@matthijskooijman do not break, this defined is redudant.

I try to solve more warnings.
Full list of warnings is following.

In file included from ..\src\bitlash\src/bitlash-cmdline.c:36:0,
from ..\src\bitlash\bitlash.cpp:49:
..\src\bitlash\src/bitlash.h:723:16: warning: extra tokens at end of #ifndef directive [enabled by default]
#ifndef GPIOR0 || GPIOR1
^
..\src\bitlash\src/bitlash-functions.c: In function 'void dofunctioncall(uint8_t)':
..\src\bitlash\src/bitlash.h:422:37: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
#define pgm_read_word(b) (*(int *)(b))
^
..\src\bitlash\src/bitlash-functions.c:493:26: note: in expansion of macro 'pgm_read_word'
fp = (bitlash_function) pgm_read_word(&function_table[entry]);
^
In file included from ..\src\bitlash\bitlash.cpp:58:0:
..\src\bitlash\src/bitlash-taskmgr.c: In function 'long unsigned int millisUntilNextTask()':
..\src\bitlash\src/bitlash-taskmgr.c:122:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (waketime[slot] < next_wake_time) next_wake_time = waketime[slot];
^

@matthijskooijman
Copy link

From the warnings you pasted, the first one about GPIO, I've already solved in my pullrequest. For the other two, I don't have fixes yet, so I'm happy to get fixes for that.

@murilopontes murilopontes closed this by deleting the head repository Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants