Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add collection arg #125

Merged
merged 1 commit into from
Sep 19, 2024
Merged

cli: Add collection arg #125

merged 1 commit into from
Sep 19, 2024

Conversation

A6GibKm
Copy link
Collaborator

@A6GibKm A6GibKm commented Sep 7, 2024

No description provided.

@A6GibKm A6GibKm changed the title Cli add collection arg cli: Add collection arg Sep 7, 2024
portal/src/main.rs Outdated Show resolved Hide resolved
@bilelmoussaoui
Copy link
Owner

Can you rebase this one please?

@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 10, 2024

Can you rebase this one please?

Rebased, but I think we should use Login. Note too that this string is translatable in other projects.

@bilelmoussaoui
Copy link
Owner

Can you rebase this one please?

Rebased, but I think we should use Login. Note too that this string is translatable in other projects.

Hmm, that makes providing both the helper methods & constants weird. As the CLI tool could become translatable, not the oo7 library itself...

@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 10, 2024

Can you rebase this one please?

Rebased, but I think we should use Login. Note too that this string is translatable in other projects.

Hmm, that makes providing both the helper methods & constants weird. As the CLI tool could become translatable, not the oo7 library itself...

Sounds like a problem for tomorrow, but it makes sense to have it translatable everywhere.

@bilelmoussaoui
Copy link
Owner

Can you rebase this one please?

Rebased, but I think we should use Login. Note too that this string is translatable in other projects.

Hmm, that makes providing both the helper methods & constants weird. As the CLI tool could become translatable, not the oo7 library itself...

Sounds like a problem for tomorrow, but it makes sense to have it translatable everywhere.

I went ahead and add various helper APIs here that makes the whole thing nicer while allowing people to translate things if they want to.

cli/src/main.rs Outdated Show resolved Hide resolved
@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 18, 2024

rebased, but please don't merge just yet, the arg is not properly working , e.g.

$ cargo run -- search --collection c a=b
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.40s
     Running `/var/home/msandova/Projects/oo7/target/debug/oo7-cli search --collection c a=b`
error: unexpected argument '--collection' found

  tip: to pass '--collection' as a value, use '-- --collection'

Usage: oo7-cli search [OPTIONS] [ATTRIBUTES]...

For more information, try '--help'.

Copy link
Owner

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm, once you solved the cli arg parser issue :)

cli/src/main.rs Outdated Show resolved Hide resolved
@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 18, 2024

otherwise lgtm, once you solved the cli arg parser issue :)

Done, it was a matter of using global=true.

@bilelmoussaoui bilelmoussaoui merged commit 6d2ef6c into main Sep 19, 2024
7 checks passed
@bilelmoussaoui bilelmoussaoui deleted the cli-add-collection-arg branch September 19, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants