-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add collection arg #125
Conversation
Can you rebase this one please? |
Rebased, but I think we should use |
e69adb7
to
198b1fb
Compare
Hmm, that makes providing both the helper methods & constants weird. As the CLI tool could become translatable, not the oo7 library itself... |
Sounds like a problem for tomorrow, but it makes sense to have it translatable everywhere. |
I went ahead and add various helper APIs here that makes the whole thing nicer while allowing people to translate things if they want to. |
rebased, but please don't merge just yet, the arg is not properly working , e.g.
|
198b1fb
to
6690da0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm, once you solved the cli arg parser issue :)
6690da0
to
86c0672
Compare
Done, it was a matter of using global=true. |
No description provided.