Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portal: Keyring::load() verify secret before returning a Keyring #122

Closed
wants to merge 2 commits into from
Closed

portal: Keyring::load() verify secret before returning a Keyring #122

wants to merge 2 commits into from

Commits on Sep 12, 2024

  1. portal: Keyring::load() verify secret before returning a Keyring 

    Adds `verify_secret()`.

With this change, calls to `oo7::portal::Keyring::load()`, and
`oo7::portal::Keyring::open()` will fail when used with a
wrong secret/password.

Also adds a new error: `InvalidSecret`.

Signed-off-by: Dhanuka Warusadura <[email protected]>
    @warusadura
    warusadura committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    24c40dd View commit details
    Browse the repository at this point in the history

  2. portal: add oo7::portal::Keyring::verify_secret() 

    This change introduces verify_keyring_secret() to verify the secret
associated with a keyring.
Note: we need this change for the sever side implementation.
Specifically we need this to verify the secret during prompt based keyring
unlock.

Signed-off-by: Dhanuka Warusadura <[email protected]>
    @warusadura
    warusadura committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a16c422 View commit details
    Browse the repository at this point in the history